♻️ Remove usage of plainPassword for User #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t2d
reviewed
Sep 18, 2024
| @@ -34,25 +30,12 @@ public function onLogin(LoginEvent $event): void | |||
| } | |||
|
|
|||
| private function handleLogin(User $user): void | |||
| { | |||
| // update password hash if necessary | |||
There was a problem hiding this comment.
Don't you think we'll need this functionality in the future?
There was a problem hiding this comment.
No, I don't see it for the future, to be honest.
There was a problem hiding this comment.
But how do you think, we'll do updates to future hashing algorithms?
There was a problem hiding this comment.
We decide and implement it when it is necessary. At the moment it is dead code.
0x46616c6b
force-pushed
the
Remove-PlainPasswordTrait-from-User
branch
from
85d7dd2
to
34110af
Compare
|
0x46616c6b
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.